On Tue, Jun 02, 2015 at 06:26:09PM +0200, Javier Celaya wrote: > El Martes, 2 de junio de 2015 14:33:35 Christophe Fergeau escribió: > > My last remaining comment about this patch is that now the client can > > force the server to use a given compression method. This is something > > the server admin might not want to allow (think "too expensive > > compression methods). > > Maybe image_compression should default to SPICE_IMAGE_COMPRESS_DEFAULT > > rather than _AUTO_GLZ, and we should only allow > > display_channel_handle_preferred_compression() to override > > COMPRESS_DEFAULT, but not other values? > > > > Christophe > > I see. However, currently, QEMU always sets image_compression to the one it gets > from command-line or _AUTO_GLZ by default. There is no way to know from within > spice-server whether the admin specified an image compression method or not, > without patching QEMU too. Ah hrm, spice-server has an _AUTO_GLZ default value, but QEMU indeed forces the default too, so we can't change this only with spice-server changes. We could forbid the client from changing compression when it's != AUTO_GLZ, but that probably be weird/unexpected? Christophe
Attachment:
pgpzJGu5xSZfy.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel