Re: [PATCH spice-gtk v3 3/3] Display: Send a preferred compression message on init.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



El Martes, 2 de junio de 2015 14:26:58 Christophe Fergeau escribió:

> I'd deal with the "preferred_compression >=

> SPICE_IMAGE_COMPRESS_ENUM_END" case with a g_warn_if_fail() as

> g_param_spec_enum should guarantee that you won't get a value not

> covered by the registered GEnum.

>

> Christophe

 

Then I shouldn't check it at all... After all, there is no check for the other two properties in that function (cache-size and glz-window-size). I would rather remove the "preferred_compression < SPICE_IMAGE_COMPRESS_ENUM_END" condition.
--



Javier Celaya

Software Engineer

javier.celaya@xxxxxxxxxxx

+34 976 512 433

@j_celaya

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]