> > On Wed, May 27, 2015 at 8:47 AM, Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx> > wrote: > > On Wed, May 27, 2015 at 6:03 AM, Frediano Ziglio <fziglio@xxxxxxxxxx> > > wrote: > >> This set of patches mainly contains fix for some memory issues > >> using quite aggressively surfaces and other minor problems like > >> images going black after a while. > >> > >> Frediano Ziglio (11): > >> Do not cause spice-server to clean our objects > >> Do not leak memory if qxl_release_list_add fails > >> Fix print statement not using uninitialized variable > >> Avoid double free on error > >> Handle all errors in qxl_surface_evict > >> Fix return for qxl_release_alloc > >> Handle correctly failures in qxl_alloc_relase_reserved > >> Remove format string errors > >> Move main reference counter to GEM object instead of TTM ones > >> Simplify cleaning qxl processing command > >> Propagate correctly errors from qxlhw_handle_to_bo > >> > >> qxl/qxl_cmd.c | 11 ++++++----- > >> qxl/qxl_display.c | 2 +- > >> qxl/qxl_drv.h | 2 +- > >> qxl/qxl_gem.c | 10 ++++++++-- > >> qxl/qxl_ioctl.c | 46 +++++++++++++++++----------------------------- > >> qxl/qxl_object.c | 11 ++++------- > >> qxl/qxl_release.c | 13 +++++++++---- > >> 7 files changed, 46 insertions(+), 49 deletions(-) > > > > The strip level on these patches is rather odd. Normally one would > > see a strip level of 1 at the top of the kernel dir. E.g. > > > > drivers/gpu/drm/qxl/qxl_gem.c > > > > in the diffstat, etc. > > (Sorry for the double reply.) > > Also, are any of these commits something that should be queued for > stable kernel releases? There are a handful that look like they > should be to me. > > josh > Hi, no problem for double reply. I was using a different repository with only QXL driver. I tested and all patches apply and compile perfectly even with Linus master branch. About which patches should be applied surely (attempting to put a priority) - "Move main reference counter to GEM object instead of TTM ones" this can causes memory corruption even not wanting to; - "Avoid double free on error" this can be cause leaks in kernel if user space wants, mitigated by the fact that usually DRM inodes are owned by root; - "Handle all errors in qxl_surface_evict" could cause corruption too, not really probable but taking into account that Xorg implementation use a lot signals is not so impossible; - "Handle correctly failures in qxl_alloc_relase_reserved", "Do not leak memory if qxl_release_list_add fails" just cause leaks on situation where memory is already REALLY low, can be omitted; - "Fix print statement not using uninitialized variable", "Remove format string errors" should just print garbage and debugging is disabled by default, not necessary. Frediano _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel