Re: [PATCH 11/13] jhbuildrc: using system icons and files not needed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey, sorry for the late reply on this one, I was testing it again

On Tue, May 12, 2015 at 04:34:42PM +0200, Christophe Fergeau wrote:
> On Thu, Apr 30, 2015 at 06:59:12PM +0200, Victor Toso wrote:
> > ---
> >  jhbuildrc | 9 ---------
> >  1 file changed, 9 deletions(-)
> > 
> > diff --git a/jhbuildrc b/jhbuildrc
> > index 4cfff9b..cfffb88 100644
> > --- a/jhbuildrc
> > +++ b/jhbuildrc
> > @@ -18,15 +18,6 @@ checkoutroot = os.path.join(os.environ['HOME'], 'spice')
> >  # All module binaries will be in $HOME/spice-usr/ after the checkout
> >  prefix = os.path.join(os.environ['HOME'], 'spice-usr')
> >  
> > -# Look in /usr/share for icons, D-BUS service files, etc
> > -addpath('XDG_DATA_DIRS', '/usr/share')
> > -# Look in /etc/xdg for system-global autostart files
> > -addpath('XDG_CONFIG_DIRS', '/etc/xdg')
> > -
> > -os.environ['ACLOCAL'] = 'aclocal -I ' + os.path.join(prefix, 'share', 'aclocal')
> > -os.environ['PKG_CONFIG_PATH'] = os.path.join(prefix, 'lib', 'pkgconfig') \
> > -    + ':' + os.path.join(prefix, 'share', 'pkgconfig')
> > -
> >  # custom CFLAGS / environment pieces for the build
> >  # os.environ['CFLAGS'] = '-Wall -g -O0'
> 
> Hmm why not, though this reverts
> aad4ec8e487aac77fb7a4e95c9861d8e14819544
> Has there been changes in jhbuild to handle this better?

In fact, this should stay as it is. The reason I changed it is due the
fact `aclocal -I ...` fails on spice-protocol with:
aclocal: error: couldn't open directory 'm4': No such file or directory

I'm removing this patch from the series and fix the issue properly.

Thanks,
- toso
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]