Re: [spice-gtk][PATCH] spicy: Fix error msg dialog created without parent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 21, 2015 at 7:13 PM, Jonathon Jongsma <jjongsma@xxxxxxxxxx> wrote:
> I'm not entirely sure why this message exists, but I suspect it is so
> that the dialog can be centered on its parent, etc. The gtk+ commit that
> introduced this message states:
>
>     We want make it mandatory for dialogs to have transient parents,
>     eventually. This is a first step in that direction.
>
> Creating a fake parent window might avoid that message for now, but it
> will almost certainly not satisfy the spirit of that warning. So I'm not
> a fan of adding this sort of hack. I suspect that the gtk+ developers
> would simply tell us that we should be using a GtkWindow instead of a
> GtkDialog if we don't have a parent for it. Maybe there are other
> solutions though.

I agree with Jonathon about the proper solution using a GtkWindow
instead of a Dialog.
The same should be done on virt-viewer/remote-viewer code.


Best Regards,
-- 
Fabiano Fidêncio
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]