Re: [spice-gtk PATCH v2 4/5] tests: fix leaks from pipes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On Tue, May 19, 2015 at 4:34 PM, Victor Toso <victortoso@xxxxxxxxxx> wrote:
+    /* The PipeInputStream and PipeOutputStream are not automatically freed
+     * from GIOStream */
+    g_clear_object(&fixture->op1);
+    g_clear_object(&fixture->op2);
+    g_clear_object(&fixture->ip1);
+    g_clear_object(&fixture->ip2);
+

That looks wrong. g_io_stream_get_{in,out}put_stream() do not return references. The fix should be elsewhere.


--
Marc-André Lureau
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]