Hi
--
On Mon, May 18, 2015 at 9:09 AM, Victor Toso <victortoso@xxxxxxxxxx> wrote:
PipeInputStream and PipeOutputStream should not fail when creating
GPollableStream source. It is already checked and unref in case of
existing source.
The check is about making sure that either the source is NULL or it is destroyed.
As such it looks fine to me, or it might leak since the condition to unref might not be reached.
Do you have a test case for the issue you encoutered?
Do you have a test case for the issue you encoutered?
---
gtk/giopipe.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/gtk/giopipe.c b/gtk/giopipe.c
index 440cae9..32fa4fa 100644
--- a/gtk/giopipe.c
+++ b/gtk/giopipe.c
@@ -234,9 +234,6 @@ pipe_input_stream_create_source (GPollableInputStream *stream,
PipeInputStream *self = PIPE_INPUT_STREAM(stream);
GSource *pollable_source;
- g_return_val_if_fail (self->source == NULL ||
- g_source_is_destroyed (self->source), NULL);
-
if (self->source && g_source_is_destroyed (self->source))
g_source_unref (self->source);
@@ -416,9 +413,6 @@ pipe_output_stream_create_source (GPollableOutputStream *stream,
PipeOutputStream *self = PIPE_OUTPUT_STREAM(stream);
GSource *pollable_source;
- g_return_val_if_fail (self->source == NULL ||
- g_source_is_destroyed (self->source), NULL);
-
if (self->source && g_source_is_destroyed (self->source))
g_source_unref (self->source);
--
2.4.1
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Marc-André Lureau
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel