On Thu, Apr 30, 2015 at 07:45:52AM -0400, Frediano Ziglio wrote: > > > > On Thu, Apr 23, 2015 at 08:22:24AM -0400, Frediano Ziglio wrote: > > > Including directly shlobj.h in some MingW environment lead to some missing > > > definitions error. Including windows.h before fix the problem. > > > > This one should be fixed by > > https://admin.fedoraproject.org/updates/FEDORA-2015-6934/mingw-crt-4.0.2-1.fc22,mingw-headers-4.0.2-1.fc22,mingw-winpthreads-4.0.2-1.fc22,mingw-winstorecompat-4.0.2-1.fc22 > > I'd tend to drop the patch, let me know if you think it really should go > > in :) > > > > Christophe > > > > Hard to say. On one side the fix in MingW allow to include the header > directly as Microsoft one does. On the other side given that agent > could be compiled with a lot of different environments (different > Linux and versions) and usually these changes are not picked up very > often probably many users would benefit from it. > The patch for instance is just on Fedora repositories, I think will > take quite long to go on different Linuxes. Ah, I expected the fix to be in the 4.0.2 release, which would have made 4.0.1 the only release with this issue, but it's actually still a separate patch. I'll push this patch upstream then. Christophe
Attachment:
pgptmcXsK5aJ9.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel