Hey, ACK. Christophe On Wed, Apr 22, 2015 at 05:58:19PM +0200, Marc-André Lureau wrote: > GSocketClient uses the system proxy by default, and it may end up using > the system HTTP proxy with bad results if CONNECT is not > supported. spice-gtk uses it's own SPICE_PROXY instead, and doesn't rely > on GSocketClient default proxy but GProxyAddress instead. Disabling the > default proxy solve a wrong proxy from being used. > > It may be worth to revisit this change if GSocketClient can be told to > ignore proxies that are not eligible for Spice connections. (HTTP could > be though, in which case it would be a user configuration issue) > > Fixes: > https://bugzilla.redhat.com/show_bug.cgi?id=1040679 > --- > gtk/spice-session.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gtk/spice-session.c b/gtk/spice-session.c > index 1a68d7d..23eb4a8 100644 > --- a/gtk/spice-session.c > +++ b/gtk/spice-session.c > @@ -2128,6 +2128,7 @@ GSocketConnection* spice_session_channel_open_host(SpiceSession *session, SpiceC > } > > open_host.client = g_socket_client_new(); > + g_socket_client_set_enable_proxy(open_host.client, FALSE); > g_socket_client_set_timeout(open_host.client, SOCKET_TIMEOUT); > > g_idle_add(open_host_idle_cb, &open_host); > -- > 2.1.0 > > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/spice-devel
Attachment:
pgplMLdvc0aXQ.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel