On Mon, Apr 13, 2015 at 09:15:40AM -0400, Marc-André Lureau wrote: > > I tend to read that as "it's safe today", it sounds it would be safer to > > keep both? Or add c->has_error = FALSE explicitly in the fd case before > > the reconnect: label, and have g_warn_if_fail(!c->has_error); right > > after the connected label? > > > > No, it should remain safe. c->has_error is really meant to be used after > the connection to spice server is established when it starts using > spice_channel_read/write*(). Well, it's currently meant to be used this way and mean that, nothing guarantees that we won't need to slightly change its semantics in the future to handle whatever corner case in the SSL connection... I don't care too much, so ACK to whatever version of the patch you decide to push. Christophe
Attachment:
pgpYj8UE7LEAR.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel