Re: [spice-gtk PATCH v5 4/4] agent: sync guest audio with client values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,
On Fri, Apr 03, 2015 at 04:34:30PM +0200, Marc-André Lureau wrote:
> Hi
>
> On Fri, Apr 3, 2015 at 3:53 PM, Victor Toso <victortoso@xxxxxxxxxx> wrote:
>
> > +    SPICE_AUDIO_GET_CLASS(audio)->get_playback_volume_info_async(audio,
> > +            audio_playback_volume_info_cb, main_channel);
> >
>
> It would need to keep a reference on main_channel, and an
> audio_sync_cancellable for the case where the channel is to be disconnected.
> 
> Also, a channel may be recycled. The state should be reset in
> channel_reset() for further usages.

Sorry, I did not understand why I need to keep a reference to
main_channel in this case and what should be done when the
channel-playback or channel-record is reset.

Could you please clarify?

Thanks,
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]