Re: [PATCH spice-gtk 3/4] main: add spice_main_update_display_enabled()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

----- Original Message -----
> To me this feels like internal API. I can't think of any reason that an
> application would call _update_display_enabled() with update==FALSE. Do
> we need to expose this function publicly?

The goal is to leave full control to an application on when to send
monitor config, and not rely on default auto-resize timer that was
introduced a long time ago. We already introduced spice_main_update_display()
and spice_main_send_monitor_config() for those reasons, I think it
makes sense to have a similar "update" function for enabling/disabling displays.

It needs to be public for applications that want to call it, and for spice-gtk
(a different library) to use it instead of the legacy timer-based.

> Also, typo in commit message: "sendi"

ok, thanks
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]