Hi ----- Original Message ----- > On Mon, Mar 30, 2015 at 10:28:56AM -0400, Marc-André Lureau wrote: > > Hi > > > > ----- Original Message ----- > > > > No :) But I would rather make get_volume() async to properly sync when > > > > volume is received (and wait sync before playback/record start to avoid > > > > glitch) > > > > > > Fair enough. I will: > > > - remove the volume-restore that I just added; > > > > I actually thought that was a good idea, instead of subscribing to events. > > Sorry, I expressed myself badly. > I only thought about using this restore when the stream was not created > otherwise pa_context_get_sink_input_info sounds more correct. > Does it sound okay? > (restore gets values from file, the latter from pulse server) I would just pick one of the two methods, so since restore is better because it handles "cold state" volume, then use that. > > > - include async calls to spice-audio (keeping the sync); > > > > Why do you want to keep the sync version? > > Just to keep gstreamer as it is. > Do you think async only is enough? You can quite easily wrap gstreamer sync calls with a GSimpleAsyncResult (see docs) _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel