Re: [PATCH] hmp: info spice: take out webdav

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/03/2015 03:31 AM, Gerd Hoffmann wrote:
> Obvious suggestion for the next spice-protocol
> release: Add some way to #ifdef new stuff.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
> ---
>  hmp.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/hmp.c b/hmp.c
> index eacfb1b..71c28bc 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -561,7 +561,12 @@ void hmp_info_spice(Monitor *mon, const QDict *qdict)
>          [SPICE_CHANNEL_SMARTCARD] = "smartcard",
>          [SPICE_CHANNEL_USBREDIR] = "usbredir",
>          [SPICE_CHANNEL_PORT] = "port",
> +#if 0
> +        /* minimum spice-protocol is 0.12.3, webdav was added in 0.12.7,
> +         * no easy way to #ifdef (SPICE_CHANNEL_* is a enum).  Disable
> +         * as quick fix for build failures with older versions. */
>          [SPICE_CHANNEL_WEBDAV] = "webdav",
> +#endif
>      };
>  
>      info = qmp_query_spice(NULL);
> 

Hmm sorry about that.

Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx>

- Cole
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]