Re: [spice-common 1/2] ppc: Fix lz magic endianness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2015-02-10 at 10:13 +0100, Christophe Fergeau wrote:
> Ping?

Hmm. A lot of memories being revisited after seen my name there.
The series looks okay for me, but I do not have a way to test.
Let's wait for ppc's tests on IRC and them push the series according to
his complaints.

> 
> On Mon, Dec 15, 2014 at 12:14:57PM +0100, Christophe Fergeau wrote:
> > From: Erlon Cruz <erlon.cruz@xxxxxxxxxxxxxxxxxx>
> > 
> > Signed-off-by: Erlon R. Cruz <erlon.cruz@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Rafael F. Santos <fonsecasantos.rafael@xxxxxxxxx>
> > Signed-off-by: Fabiano Fidêncio <Fabiano.Fidêncio@xxxxxxxxxxxxxxxxxxxxx>
> > ---
> >  common/lz.c      |  4 +++-
> >  configure.ac     |  1 +
> >  m4/spice-deps.m4 | 12 ++++++++++++
> >  3 files changed, 16 insertions(+), 1 deletion(-)
> > 
> > diff --git a/common/lz.c b/common/lz.c
> > index d1c4033..2350152 100644
> > --- a/common/lz.c
> > +++ b/common/lz.c
> > @@ -47,6 +47,8 @@
> >  #include <config.h>
> >  #endif
> >  
> > +#include <glib.h>
> > +
> >  #include "spice_common.h"
> >  #include "lz.h"
> >  
> > @@ -537,7 +539,7 @@ int lz_encode(LzContext *lz, LzImageType type, int width, int height, int top_do
> >          encoder->usr->error(encoder->usr, "lz encoder reading image segments failed\n");
> >      }
> >  
> > -    encode_32(encoder, LZ_MAGIC);
> > +    encode_32(encoder, GUINT32_TO_LE(LZ_MAGIC));
> >      encode_32(encoder, LZ_VERSION);
> >      encode_32(encoder, type);
> >      encode_32(encoder, width);
> > diff --git a/configure.ac b/configure.ac
> > index 32d4c4d..73102c0 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -39,6 +39,7 @@ AC_SUBST(PROTOCOL_CFLAGS)
> >  SPICE_CHECK_PIXMAN(SPICE_COMMON)
> >  SPICE_CHECK_SMARTCARD(SPICE_COMMON)
> >  SPICE_CHECK_CELT051(SPICE_COMMON)
> > +SPICE_CHECK_GLIB2(SPICE_COMMON)
> >  SPICE_CHECK_OPUS(SPICE_COMMON)
> >  SPICE_CHECK_OPENGL(SPICE_COMMON)
> >  AC_SUBST(SPICE_COMMON_CFLAGS)
> > diff --git a/m4/spice-deps.m4 b/m4/spice-deps.m4
> > index 0815766..e5eb7fd 100644
> > --- a/m4/spice-deps.m4
> > +++ b/m4/spice-deps.m4
> > @@ -141,3 +141,15 @@ AC_DEFUN([SPICE_CHECK_PIXMAN], [
> >      AS_VAR_APPEND([$1_CFLAGS], [" $PIXMAN_CFLAGS"])
> >      AS_VAR_APPEND([$1_LIBS], [" $PIXMAN_LIBS"])
> >  ])
> > +
> > +
> > +# SPICE_CHECK_GLIB2(PREFIX)
> > +# --------------------------
> > +# Check for the availability of glib2. If found, it will append the flags to
> > +# use to the $PREFIX_CFLAGS and $PREFIX_LIBS variables.
> > +#---------------------------
> > +AC_DEFUN([SPICE_CHECK_GLIB2], [
> > +    PKG_CHECK_MODULES(GLIB2, glib-2.0)
> > +    AS_VAR_APPEND([$1_CFLAGS], [" $GLIB2_CFLAGS"])
> > +    AS_VAR_APPEND([$1_LIBS], [" $GLIB2_LIBS"])
> > +])
> > -- 
> > 2.1.0
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/spice-devel

Best Regards,
--
Fabiano Fidêncio

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]