On Thu, Jan 29, 2015 at 06:23:49AM -0500, Marc-André Lureau wrote:
> Hi
>
> ----- Original Message -----
> > Initial SPICE connection can sometimes fail without clear indications
> > where/how it failed. This commit adds more debug logs/more accurate logs
> > in order to help narrow down such issues.
> > ---
> > gtk/spice-session.c | 19 ++++++++++++++-----
> > 1 file changed, 14 insertions(+), 5 deletions(-)
> >
> > diff --git a/gtk/spice-session.c b/gtk/spice-session.c
> > index 7f15d98..a62d533 100644
> > --- a/gtk/spice-session.c
> > +++ b/gtk/spice-session.c
> > @@ -1924,10 +1924,12 @@ static void socket_client_connect_ready(GObject
> > *source_object, GAsyncResult *re
> > spice_open_host *open_host = data;
> > GSocketConnection *connection = NULL;
> >
> > - SPICE_DEBUG("connect ready");
> > + CHANNEL_DEBUG(open_host->channel, "connect ready");
>
> In which case adding the channel name helps for debugging connection?
> but I don't mind, so ack
This one was mostly for consistency as most logs around it had the
channel name, and knowing exactly which channel is connecting can be
useful.
Christophe
Attachment:
pgpfyQtgzwlhR.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel