Re: [PATCHv2 08/10] session: prettify query parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 27, 2015 at 02:53:21PM +0100, Marc-André Lureau wrote:
> Use & as parameters separators, this is more conventionnal. Remove

'conventional' (common/usual ?)

ACK otherwise

> trailing one, no further parameters are useful anyway.
> ---
>  gtk/spice-session.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gtk/spice-session.c b/gtk/spice-session.c
> index a13d654..9738e69 100644
> --- a/gtk/spice-session.c
> +++ b/gtk/spice-session.c
> @@ -365,10 +365,10 @@ static gchar* spice_uri_create(SpiceSession *session)
>          g_string_append(str, s->host);
>          g_string_append(str, "?");
>          if (s->port != NULL) {
> -            g_string_append_printf(str, "port=%s;", s->port);
> +            g_string_append_printf(str, "port=%s&", s->port);
>          }
>          if (s->tls_port != NULL) {
> -            g_string_append_printf(str, "tls-port=%s;", s->tls_port);
> +            g_string_append_printf(str, "tls-port=%s", s->tls_port);
>          }
>          return g_string_free(str, FALSE);
>      }
> -- 
> 2.1.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: pgpeR7ZkwktMT.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]