Re: [spice-gtk] spice_parse_uri: Don't try to free unallocated string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/27/2015 12:05 PM, Christophe Fergeau wrote:
When it encounters an URI with a path, spice_parse_uri ignores it (with
a runtime warning). However, it does not strdup the path component, so
it's wrong to try to free it in the end/fail blocks.
---
  gtk/spice-session.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/gtk/spice-session.c b/gtk/spice-session.c
index 2dec8c7..3b86e80 100644
--- a/gtk/spice-session.c
+++ b/gtk/spice-session.c
@@ -523,7 +523,6 @@ end:
  fail:
      g_free(uri);
      g_free(unescaped_path);
-    g_free(path);
      g_free(host);
      g_free(port);
      g_free(tls_port);

Hi Christophe,

I don't see this line in the code (master branch).
Is it based on yet uncommitted patches ?

Regards,
    Uri.

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]