Hi Jeremy, > > Hi Pavel, > > This looks (mostly) good to me. I'm really troubled by the 2K limit, > and the 5 token window size; that makes transfers painfully slow. > That > is arguably outside the scope of this patch set, though. > In spice-gtk we are also sending 2K agent data messages and it is working fine, maybe implementing websocket support for the spice server as it is mentioned in the TODO file could help. > > I did find one issue: in handling SPICE_MSG_MAIN_INIT in main.js, you > need to set the number of agent_tokens first thing. Otherwise, the > connect_agent() call tries to send a monitor config that doesn't go > out > right away. > My bad, fix: http://lists.freedesktop.org/archives/spice-devel/2015-January/018600.html > > I'm happy to ACK and push these and then fix that, or you can send a > revision; your choice. > > > More broadly, I would ask a further favor, though: we should file a > bug > or somehow make sure we have recorded some of the less that ideal > behaviors in Spice's file transfer stuff: > * 2K limit I believe the problem is somewhere else as it is working with spice-gtk. The limit is checked in spice-server: http://cgit.freedesktop.org/spice/spice/tree/server/agent-msg-filter.c#n43 > * no progress dialog > * file truncated to max size > > So they don't get lost. > I file RFEs or send patches, today. Thanks a lot for the review, Pavel _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel