Re: Patch to support LZ4 compression algorithm‏‏

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



has anybody tried this feature and encountered the displaying problems?

I just made a small change to enable lz4, but the image turns out to be broken (see the screenshots). 
And I observed that it goes wrong only for the SpiceBitmap w/o SPICE_BITMAP_FLAGS_TOP_DOWN flag in the red_compress_image() function from red_worker.c .

2014-11-14 0:11 GMT+08:00 Javier Celaya <javier.celaya@xxxxxxxxx>:
>
> Hello
>
> There they go.
>
> However, don't forget that, since spice-protocol is a submodule of spice-
> common, once you push the commit for spice-protocol, the commit for spice-
> common should point to it. The same with spice and spice-gtk in relation to
> spice-common.
>
> Regards
>
> El Jueves, 13 de noviembre de 2014 16:04:00 Christophe Fergeau escribió:
>> Hey,
>>
>> On Fri, Nov 07, 2014 at 10:17:11AM +0100, Javier Celaya wrote:
>>> Hello
>>>
>>> I resend the patch for the spice repository. I just realized I forgot to
>>> remove a debug message from red_worker.c, sorry.
>>
>> Thanks for the updated patches, they look good to me. There are 2 blank
>> lines at the end of lz4_encoder.[ch] which should be removed.
>> Can you resend these patches generated with git-format-patch so that
>> they contain a commit log, and an author name/address? Then they can be
>> pushed upstream.
>>
>> Christophe
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
> 		 	   		  

Attachment: Screenshot-spice display 0.jpg
Description: JPEG image

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]