On Mon, Dec 08, 2014 at 04:34:18PM +0100, Marc-André Lureau wrote: > On Mon, Dec 8, 2014 at 4:25 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > > « **if a recently committed patch** breaks compilation on a platform or > > for a given driver, then it's fine to commit a **minimal** fix directly > > without getting the review feedback first » > > What is minimal? The resulting file is a dozen lines long and idiomatic. A minimal fix is one with the smallest diffstat possible. autogen.sh | 167 ++++++-------------------------------------------------------------------------------- 1 file changed, 10 insertions(+), 157 deletions(-) I don't think you needed to change 167 lines just to fix out-of-tree autogen.sh. > > What does recently mean? What if something never worked in the first place? Recently would be in the last few hours/days. If something never worked, then it's not an urgent fix and should be sent for review. > We can always add more strict and more defined rules, but the better > will often be the enemy of the good. And it will remain subjective in > the end. Well, in this case, most people in this thread agreed the patch was not trivial. Since you felt differently about it and thought it was eligible to being pushed without review, I think these rules should give some guidelines in the future about what should be fine to push, and what is going to cause another complaint on spice-devel. I don't think anyone will complain for patches with a diffstat with less than 5 lines changed which match the criteria in that HACKING file. Just send everything else to the mailing list for review, and everything will be fine. Christophe
Attachment:
pgpVoQ9GmSJDD.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel