[PATCH spice-gtk 14/15] session: keep a reference on disconnect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



It is idiomatic for client code to clean up it's reference on channel
disconnection. Keeping a reference during disconnect help solving
potential crashes if the session is unref during callbacks.
---
 gtk/spice-session.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gtk/spice-session.c b/gtk/spice-session.c
index f0347db..e00e2b3 100644
--- a/gtk/spice-session.c
+++ b/gtk/spice-session.c
@@ -1740,6 +1740,7 @@ void spice_session_disconnect(SpiceSession *session)
     if (s->disconnecting)
         return;
 
+    g_object_ref(session);
     s->disconnecting = TRUE;
     s->cmain = NULL;
 
@@ -1757,6 +1758,7 @@ void spice_session_disconnect(SpiceSession *session)
 
     spice_session_abort_migration(session);
     s->disconnecting = FALSE;
+    g_object_unref(session);
 }
 
 /**
-- 
2.1.0

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]