On Tue, Nov 18, 2014 at 04:13:09PM +0100, Marc-André Lureau wrote: > On Tue, Nov 18, 2014 at 4:02 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > > On Fri, Nov 14, 2014 at 12:32:42AM +0100, Marc-André Lureau wrote: > >> This is a workaround for existing clients such as virt-viewer that do > >> not hold a reference to their sessions when calling > >> spice_session_disconnect() and crash now that channels are removed from > >> session during the call. They expect disconnection events to be deferred > >> instead, let's defer actual disconnection to idle time for public > >> disconnect API for compatibility reasons (it is still recommended to fix > >> client code, for eventual future iterations) > > > > I'm afraid these changes are causing more issues. For example, > > virt-viewer --reconnect + virsh destroy expects the session to stay > > alive long enough, I needed this in order to fix it > > > > What you mean by "these changes"? I suspect you mean starting from > "session: remove channels on disconnect". Can we already push the rest > of the changes proposed here? I've acked 1 through 13 or something like that iirc, expecting these would get push yeah. > This doesn't really explain what is happening. So I can't tell if it's > virt-viewer programming error or not. This might happen with upstream actually, even though I'm fairly sure at some point today I Tested and this was not happening ;) I'll investigate more. > > > > I suspect these are not the only places which could be impacted by such issues :( > > > > fud? :) Well, no, in order to keep existing code to work, this _idle workaround was needed, then while I was not even to trying to test these changes, I hit an issue introduced by these patches, I definitely expect a few more to be lurking around. Christophe
Attachment:
pgp6ueyJOICeV.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel