Hi ----- Original Message ----- > On Sun, Nov 09, 2014 at 05:31:45PM +0100, Marc-André Lureau wrote: > > Wait until the main channel is reset() before initiating a reconnect. > > > > With the added precondition checks in previous patch, we hit the > > following critical otherwise: > > > > (remote-viewer:4617): GSpice-CRITICAL **: channel_connect: assertion > > 'c->sock == NULL' failed > > This check seems to be g_return_val_if_fail(c->sock == NULL, FALSE); > from spice-channel.c:channel_connect() which was not added in this > patch series (it's a very old check actually). > So not sure what's going on here. Right, I was confused about related changes. The critical happens since the main channel reset code calls set_agent_connected(), which will yield to main loop, so reconnection can't happen after calling spice_hannel_disconnect(), and must wait until the channel reset completes. _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel