Re: [PATCH spice-gtk 2/2] channel: deprecate spice_channel_destroy()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On Thu, Nov 13, 2014 at 10:10 AM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:
At first, I thought you meant that this function was no longer available
at all, causing an ABI break. After reading the full patch, it seems you
mean this function has no non-deprecated replacement. Indicating whether
this is because library users should never have called it, or because
it's no longer needed to call it because of XXX or YYY would be helpful
to people who want to get rid of deprecated calls to that method.


What about?

"
This function has been deprecated because it is misleading, the object is not actually destroyed. And it is too easy to forget that the object is unref(). Instead, it is recommended to call explicitely spice_channel_disconnect() and g_object_unref().
"

--
Marc-André Lureau
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]