Re: [PATCH xf86-video-qxl v2] Revise the XSpice audio processing to avoid the use of pthreads.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 21, 2014 at 04:00:08PM -0500, Jeremy White wrote:
>  int
>  qxl_add_spice_playback_interface (qxl_screen_t *qxl)
>  {
>      int ret;
> +    struct audio_data *data = calloc(1, sizeof(*data));
>  
> -    if (qxl->playback_fifo_dir[0] == 0)
> -    {
> +    if (qxl->playback_fifo_dir[0] == 0) {
>          ErrorF("playback: no audio FIFO directory, audio is disabled\n");
> +        free(data);

Forgot to mention that there are more error situations in this function
where it looks like data would be leaked.

Christophe

Attachment: pgp3XpPV1S2eL.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]