Looks good, ACK It seems implementing shadow_allocate should not be too hard if we need xf86CrtcRotate support at some point. Christophe On Thu, Oct 16, 2014 at 11:21:44AM +0200, Marc-André Lureau wrote: > Our driver doesn't support rotation, and calling CrtcRotoate() > may result in crash. Let's remove that useless call. > > Fixes: > http://bugzilla.redhat.com/1067709 > --- > src/qxl_drmmode.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/qxl_drmmode.c b/src/qxl_drmmode.c > index 42347e6..35d7897 100644 > --- a/src/qxl_drmmode.c > +++ b/src/qxl_drmmode.c > @@ -197,9 +197,6 @@ drmmode_set_mode_major(xf86CrtcPtr crtc, DisplayModePtr mode, > output_count++; > } > > - if (!xf86CrtcRotate(crtc)) { > - goto done; > - } > #if XORG_VERSION_CURRENT >= XORG_VERSION_NUMERIC(1,7,0,0,0) > crtc->funcs->gamma_set(crtc, crtc->gamma_red, crtc->gamma_green, > crtc->gamma_blue, crtc->gamma_size); > @@ -354,6 +351,7 @@ drmmode_crtc_init(ScrnInfoPtr pScrn, drmmode_ptr drmmode, int num) > crtc = xf86CrtcCreate(pScrn, &drmmode_crtc_funcs); > if (crtc == NULL) > return; > + crtc->driverIsPerformingTransform = FALSE; > > drmmode_crtc = xnfcalloc(sizeof(drmmode_crtc_private_rec), 1); > drmmode_crtc->mode_crtc = drmModeGetCrtc(drmmode->fd, drmmode->mode_res->crtcs[num]); > -- > 1.9.3 > > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/spice-devel
Attachment:
pgpJ2I_MNIWcP.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel