Re: [PATCH xf86-qxl] Fix crash when calling CrtcRotate()

[Marc-André Lureau <marcandre.lureau@xxxxxxxxx>]

Hi

Rob and Dave, I hope you can shed some light here.

On Thu, Sep 18, 2014 at 1:26 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:

A bit confused that we try to call something that cannot work in our
code. Can drmmode_set_mode_major report an error rather than attempting
to rotate?

It seems src/qxl_drmmode.c is based on xf86-video-modesetting code, also calling CrtcRotate:
http://cgit.freedesktop.org/xorg/driver/xf86-video-modesetting/tree/src/drmmode_display.c

Until very recently, it also implemented those stub functions:
http://cgit.freedesktop.org/xorg/driver/xf86-video-modesetting/commit/src?id=91571cce03adc58a10b5d76307629efc7c994c3e

I wonder if xf86-video-modesetting will reach the same crash now (since it also has no crtc->driverIsPerformingTransform).

maybe the call to CrtcRotate should be removed in both implementations?

--
Marc-André Lureau

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel