Hey, Yup, makes sense to me, though I can't parse the commit log. A short "It's possible to filter spice-vdagent/spice-vdagentd log messages out of /var/log/messages with journalctl SYSLOG_IDENTIFIER=spice-vdagent SYSLOG_IDENTIFIER=spice-vdagentd" would do. ACK, and hopefully we will get bug reports if someone needs the rsyslog file on a journalctl-less system. Christophe On Fri, Sep 05, 2014 at 03:18:38PM +0200, Marc-André Lureau wrote: > Many systems don't use rsyslog, others don't need seperate syslog files > for vdagent. Instead, /var/log/messages can be grep for spice-vdagent, > or system with the journal can call journalctl > SYSLOG_IDENTIFIER=spice-vdagent. > > This simplify spice-vdagent packaging and updates, since there are no > config files to deal with. > > Related: > https://bugzilla.redhat.com/show_bug.cgi?id=1136881 > --- > Makefile.am | 4 ---- > data/rsyslog.d/spice-vdagentd.conf | 4 ---- > 2 files changed, 8 deletions(-) > delete mode 100644 data/rsyslog.d/spice-vdagentd.conf > > diff --git a/Makefile.am b/Makefile.am > index 7fae742..510f460 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -51,9 +51,6 @@ gdmautostart2_DATA = $(top_srcdir)/data/spice-vdagent.desktop > install-data-local: > $(mkdir_p) $(DESTDIR)$(localstatedir)/run/spice-vdagentd > > -rsyslogdir = $(sysconfdir)/rsyslog.d > -rsyslog_DATA = $(top_srcdir)/data/rsyslog.d/spice-vdagentd.conf > - > if INIT_SCRIPT_RED_HAT > initdir = $(sysconfdir)/rc.d/init.d > init_SCRIPTS = $(top_srcdir)/data/spice-vdagentd > @@ -79,7 +76,6 @@ manpage_DATA = data/spice-vdagent.1 \ > EXTRA_DIST = \ > README.RHEL-5 \ > data/70-spice-vdagentd.rules \ > - data/rsyslog.d/spice-vdagentd.conf \ > data/spice-vdagent.desktop \ > data/spice-vdagentd \ > data/spice-vdagentd.service \ > diff --git a/data/rsyslog.d/spice-vdagentd.conf b/data/rsyslog.d/spice-vdagentd.conf > deleted file mode 100644 > index 2437ba0..0000000 > --- a/data/rsyslog.d/spice-vdagentd.conf > +++ /dev/null > @@ -1,4 +0,0 @@ > -# A template to for higher precision timestamps + severity logging > -$template SpiceTmpl,"%TIMESTAMP%.%TIMESTAMP:::date-subseconds% %syslogtag% %syslogseverity-text%:%msg:::sp-if-no-1st-sp%%msg:::drop-last-lf%\n" > - > -:programname, startswith, "spice-vdagent" /var/log/spice-vdagent.log;SpiceTmpl > -- > 1.9.3 > > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/spice-devel
Attachment:
pgpjXD99LQhZJ.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel