Re: [PATCH] [xf86-video-qxl] In XSpice mode, enable the ability to specify the various ram buffer sizes.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Actually no excuse for the top post. I see. I like the idea of making sane memory allocation. When I ''fused'' Xspice I took what I thought was was simplest. I think you can replace mspace with malloc. There is no api to disable the address translation we do (i.e. memslots) but it's already equallity. I can't think of any other complication. Yes, the framebuffer is one allocation but it can be changed on every create primary, before it actually and after the destroy primary, with realloc. Maybe even the address can be changed, I think it could, but realloc takes care of that. I guess that has some cost though.

Hmm.  Well, I just tried the brute force:
   #define mspace_malloc(m,b) malloc(b)
   #define mspace_free(m,mem) free(mem)
in qxl_mem.c and my very basic tests seemed to function.

So I guess that suggests I should explore that a little bit further :-/.

For the non vdagent case, we'll still need to have an initial frame buffer size, so that configuration option is likely to make sense regardless. Given that, I think I'll go ahead and resubmit this patch.

Cheers,

Jeremy
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]