Re: [PATCH spice-gtk 14/14] win-usb: try to connect to usbclerk during init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/24/2014 06:42 PM, Marc-André Lureau wrote:

On Thu, Apr 24, 2014 at 4:37 PM, Jonathon Jongsma <jjongsma@xxxxxxxxxx <mailto:jjongsma@xxxxxxxxxx>> wrote:


    One behavioral change to note here: with the old code, if we
    failed to create the usbclerk pipe, we would re-try to do it again
    the next time spice_win_usb_driver_op() was called.  With the new
    code, we try it once at the beginning and then never try again. I
    suspect that re-trying isn't really useful (if it failed the first
    time, it will likely fail again the next time), but I thought it
    was worth mentioning the change in behavior.


Yes, that's correct. I added a comment in the commit message (now it retries every time UsbDeviceManager is initialized).

The benefit of trying again is:
If the usbclerk service is not running, there is no need to close all clients, install/start usbclerk and rerun the clients.
Simply start the usbclerk service and try again to usbredir the device.

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]