Re: [PATCH] Make use of the new playback rate interface, if available.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



      /* disable CELT */
      ret = spice_server_set_playback_compression(qxl->spice_server, 0);
      if (ret < 0)
          return errno;
This codepath disables compression for some reason, should we do the
same in the newer codepath?

I don't think it's a valuable code path; in fact, I fear that it may have been an overlooked mistake. Looking at git blame, it was included in the initial xspice audio commit:
 9f18384a9b34da4eed3690f11575b6633c61f1a0 by Andrew Eikum.

My suspicion is that was written initially to make his work with the audio channel simpler, and was never taken out once things were working.

Andrew, do you have any further insight?

Cheers,

Jeremy
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]