On Wed, Apr 23, 2014 at 11:43 PM, Jonathon Jongsma <jjongsma@xxxxxxxxxx> wrote:
Why return FALSE without setting error? Doesn't that violate the contract for initable? From the docs:
Returns: TRUE if successful. If an error has occurred, this function will return FALSE and set error appropriately if present.
Those are programmer pre-condition checks. They should be unreachable at runtime. Anyway, they can safely be removed or moved to spice_usb_device_manager_get(), which is how I changed the patch.
--
Marc-André Lureau
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel