Re: [PATCH spice-gtk 06/14] win-usb: throw an error if reply.status != 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, Apr 24, 2014 at 4:50 PM, Jonathon Jongsma <jjongsma@xxxxxxxxxx> wrote:
I have no experience with usbclerk, but reading the code, it seems that reply.status is set to a boolean value[1], with true meaning success.  So the status!=0 below appears to be backward.  Or am I reading it wrong?

oops my bad, it should be:

 if (!priv->reply.status)

same as currently in gtk/usb-device-manager.c:
 
  if (!status) {
        g_warning("failed to %s win usb driver (status=0)", opstr);
    }




--
Marc-André Lureau
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]