Re: [PATCH 1/7] Introduce reds_stream_async_read() helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 25, 2014 at 11:58:40AM +0100, Marc-André Lureau wrote:
> On Mon, Mar 17, 2014 at 2:20 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx>wrote:
> > @@ -449,6 +446,23 @@ void async_read_handler(int fd, int event, void *data)
> >      }
> >  }
> >
> > +void reds_stream_async_read(RedsStream *stream,
> > +                            uint8_t *data, size_t size,
> > +                            AsyncReadDone read_done_cb,
> > +                            void *opaque)
> > +{
> > +    AsyncRead *obj = &stream->priv->async_read;
> > +
> >
> 
> s/obj/ async or op ?

I've sent a followup patch doing that throughout the file.

> 
> 
> > +    g_assert(!obj->stream);
> >
> 
> Safer spice_return_if_fail() ?

Yup, I just fixed it locally, thanks.

Christophe

Attachment: pgpw5V4FCTRBm.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]