[vdagent-win V2 3/6] Fix Visual Studio compiler warning (strncpy)

[Uri Lublin <uril@xxxxxxxxxx>]

Visual Studio complains:
    vdagent\file_xfer.h(28) : warning C4996: 'strncpy': This function or variable may be unsafe.
    Consider using strncpy_s instead.
    To disable deprecation, use _CRT_SECURE_NO_WARNINGS.
    See online help for details.

Replace strncpy with strcpy_s, which is implemented in both VS and mingw.
Also strcpy_s also guarantees an ending '\0'.
---
 vdagent/file_xfer.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vdagent/file_xfer.h b/vdagent/file_xfer.h
index b506f59..5426b8c 100644
--- a/vdagent/file_xfer.h
+++ b/vdagent/file_xfer.h
@@ -25,7 +25,7 @@ typedef struct ALIGN_VC FileXferTask {
     FileXferTask(HANDLE _handle, uint64_t _size, char* _name):
     handle(_handle), size(_size), pos(0) {
         // FIXME: should raise an error if name is too long..
-        strncpy(name, _name, sizeof(name) - 1);
+        sprintf_s(name, sizeof(name), _name);
     }
     HANDLE handle;
     uint64_t size;
-- 
1.8.5.3

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel