Re: [PATCHv3 spice-gtk 01/14] compat: add strtok_r fallback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 20, 2014 at 09:41:32AM -0500, Marc-André Lureau wrote:
> > > @@ -14,6 +17,7 @@
> > >     License along with this library; if not, see
> > >     <http://www.gnu.org/licenses/>.
> > >  */
> > >  
> > > +#include <string.h>
> > >  #include "glib-compat.h"
> > 
> > and glib-compat.h needs to go before string.h here.
> 
> why?

The doc says so
http://nondot.org/sabre/Mirrored/autoconf-2.12/autoconf_3.html#SEC15
I've for example had very unpleasant experience with this when this file
defines _FILE_OFFSET_BITS which changes the size of some structs in
system headers, and causes very weird bugs if different files expects
different layouts for these structs.

(half of the C files are missing config.h includes anyway, I'll send a
patch)

Christophe

Attachment: pgp9TL9AIZ5xU.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]