On Tue, Feb 11, 2014 at 6:06 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > On Tue, Feb 11, 2014 at 12:00:58PM -0500, Marc-André Lureau wrote: >> > > + } >> > > + >> > > + gchar **proxyv = g_strsplit(uri, ":", 2); >> > >> > This does not seem to be strictly related to this change. >> >> You mean 0 -> 2.. ? ok... > > (not saying this should be split out, ..., just mentioning it in case this > belongs in another patch or was not meant to be there). > It's a slight parsing improvements, just making sure we don't split more than 2 pieces. I am not fond of super-extra-small changes, I tend to make things that belong together in the same patch. This one could be splitted in 5 patches or more, I don't see the point. All I want is a reasonable set of related changes that don't break things. So should I split it or you agree it's fine as part of parsing changes? -- Marc-André Lureau _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel