On Wed, Feb 05, 2014 at 09:49:36AM +0100, Marc-André Lureau wrote: > On Wed, Feb 5, 2014 at 9:36 AM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > > On Tue, Feb 04, 2014 at 03:22:47PM +0100, Marc-André Lureau wrote: > >> On Tue, Feb 4, 2014 at 2:48 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > >> > On Wed, Jan 22, 2014 at 07:26:49PM +0100, Marc-André Lureau wrote: > >> >> From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> > >> >> > >> >> In all cases, when the coroutine is resumed, the idle source has been > >> >> removed. > >> > > >> > Are you sure about this? I see some coroutine_yieldto() in error cases in > >> > open_host_idle_cb (but I always get the coroutine code wrong). > >> > > >> > >> but the source is removed there anyway > > > > As I understand it, even if the coroutine is resumed through a > > coroutine_yieldto() during the idle execution, it will eventually be > > removed through a return G_SOURCE_REMOVE, is this what you mean ? > > yes Ok, ACK if you improve the commit log, as what I understood initially was that the idle was guaranteed to be finished/removed before we return to the coroutine context. Christophe
Attachment:
pgpORtPfuzZ9U.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel