Hey, On Tue, Dec 03, 2013 at 06:21:22PM +0100, Christophe Fergeau wrote: > On Tue, Dec 03, 2013 at 11:46:40AM -0500, i iordanov wrote: > > Would you like me to generate a patch with all the suggested changes and a > > better log entry? > > I've been doing that actually, with various changes: > - renamed allocatevm to allocate_vm > - renamed _vmpool_ to _vm_pool > - moved ovirt_vm_pool_xml.c to ovirt_vm_pool.c as it was not that big > - used guint for the various VmPool properties > - detect parsing errors when parsing numbers > - fixed the copyright headers (the new files should be (C) 2013 yourself, > not (C) 2013 Red Hat Inc) > > I still have these changes roughly split up if you don't like some of them > and want me to drop them. I've also added an async active_vm variant, and pushed all of this to http://cgit.freedesktop.org/~teuf/govirt/log/ It would be nice if you could check I did not break anything for you (I haven't tested ovirt_vm_pool_activate_vm() at all). Then I can push all of it to git master ;) Thanks, Christophe
Attachment:
pgpvvzWelZHEC.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel