On Tue, Nov 19, 2013 at 5:09 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > On Tue, Nov 19, 2013 at 11:05:13AM -0500, Marc-André Lureau wrote: >> >> >> ----- Original Message ----- >> > On Tue, Nov 19, 2013 at 04:14:22PM +0100, Marc-André Lureau wrote: >> > > Just like any other C function >> > >> > NACK, I just added this annotation as not checking its return value will >> > cause very hard to track down failures (no usable backtraces), so better to >> > force it to be checked, especially as this is only used internally. >> >> This is really different from any other C API. > > GList, GSList make extensive use of it, and it's also used in a several other > places in glib. Because they return object that contains allocated data, or are critical to there mode of working. Any other function that returns an error code doesn't have G_GNUC_WARN_UNUSED_RESULT. I'll modify the patch to abort, and return void. -- Marc-André Lureau _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel