Re: [PATCH usbclerk] Fix possibly missing files after upgrade

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/09/2013 03:34 AM, Marc-André Lureau wrote:
From: Marc-André Lureau <marcandre.lureau@xxxxxxxxx>

This is similar to the fix for virt-viewer:
https://www.redhat.com/archives/virt-tools-list/2013-November/msg00030.html

Although it's not mandatory for simple cases,
RemoveExistingProducts should be Schedule='afterInstallFinalize', see
also:

http://msdn.microsoft.com/en-us/library/aa371197%28v=vs.85%29.aspx
http://stackoverflow.com/questions/15138731/wix-major-upgrade-not-installing-all-files
---
  usbclerk.wxs.in | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/usbclerk.wxs.in b/usbclerk.wxs.in
index 8cb918a..93fb192 100644
--- a/usbclerk.wxs.in
+++ b/usbclerk.wxs.in
@@ -32,7 +32,7 @@
      </Upgrade>
      <Condition Message="USB Clerk is already installed.">NOT NEWERVERSIONDETECTED</Condition>
      <InstallExecuteSequence>
-      <RemoveExistingProducts After="InstallValidate"/>
+      <RemoveExistingProducts After="InstallFinalize"/>
      </InstallExecuteSequence>
<!-- try to uninstall NSIS -->

ACK.
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]