On Wed, Oct 30, 2013 at 03:49:37PM -0500, Jeremy White wrote:
> > On Wed, Oct 16, 2013 at 11:46:56AM -0500, Jeremy White wrote:
> >> diff --git a/gtk/channel-playback.c b/gtk/channel-playback.c
> >> index 60fc113..bcb4728 100644 --- a/gtk/channel-playback.c +++
> >> b/gtk/channel-playback.c @@ -379,18 +363,16 @@ static void
> >> playback_handle_data(SpiceChannel *channel, SpiceMsgIn *in)
> >> packet->data, packet->data_size); break; case
> >> SPICE_AUDIO_DATA_MODE_CELT_0_5_1: { - celt_int16_t pcm[256
> >> * 2]; + uint8_t pcm[SND_CODEC_CELT_FRAME_SIZE * 2 * 2]; +
> >> int n = sizeof(pcm);
> >>
> >> - g_return_if_fail(c->celt_decoder != NULL); - - if
> >> (celt051_decode(c->celt_decoder, packet->data, -
> >> packet->data_size, pcm) != CELT_OK) { + if
> >> (snd_codec_decode(c->codec, packet->data, packet->data_size, +
> >> pcm, &n) != SND_CODEC_OK) { g_warning("celt_decode() error");
> >
> > The g_warning() should no longer mention celt.
>
> Actually, I think for this patch, it should remain, because the change
> is surgical - it's still clearly in a Celt only mode.
This patch changes most other similar messages to do remove mentions
of celt, hence that comment. If it's changed later, I don't mind if we
keep it.
>
> The next set of patches change that warning. You mentioned on irc
> that you encountered a crash in qemu with these patches.
>
> Do you have any more details?
I didn't even gather a backtrace yet, I'll give more info during the day
hopefully ;)
Christophe
Attachment:
pgp5yvT63221D.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel