On Wed, Oct 23, 2013 at 01:04:48PM +0200, dietmar@xxxxxxxxxxx wrote:
> Signed-off-by: Dietmar Maurer <dietmar@xxxxxxxxxxx>
>
> Index: new/src/virt-viewer-session-spice.c
> ===================================================================
> --- new.orig/src/virt-viewer-session-spice.c 2013-07-31 13:57:28.000000000 +0200
> +++ new/src/virt-viewer-session-spice.c 2013-10-23 12:10:56.000000000 +0200
> @@ -342,6 +342,11 @@
> g_object_set(G_OBJECT(session), "password", val, NULL);
> g_free(val);
> }
> + if (virt_viewer_file_is_set(file, "username")) {
> + gchar *val = virt_viewer_file_get_username(file);
> + g_object_set(G_OBJECT(session), "username", val, NULL);
> + g_free(val);
> + }
>
> if (virt_viewer_file_is_set(file, "tls-ciphers")) {
> gchar *val = virt_viewer_file_get_tls_ciphers(file);
> @@ -468,6 +473,7 @@
> {
> VirtViewerSessionSpice *self = VIRT_VIEWER_SESSION_SPICE(session);
> gchar *password = NULL;
> + gchar *username = NULL;
>
> g_return_if_fail(self != NULL);
>
> @@ -491,12 +497,13 @@
> int ret = virt_viewer_auth_collect_credentials(self->priv->main_window,
> "SPICE",
> NULL,
> - NULL, &password);
> + &username, &password);
This seems to be asking for a username both in the SASL case when it makes
sense, but also in the usual 'ticket' case (spice-server -spice
password=foo command line option). In the latter case, we should not be
asking for a username as it is meaningless.
Christophe
Attachment:
pgpKpfMys5Blf.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel