> I think you should keep the UP flag there you had in your previous proposal (to > avoid problems of network latency, generating spurious key repeatition events > on application/guest side) OK > Why not have SUPER (win key), HYPER and META? Sure, I can add them > > > +typedef struct SPICE_ATTR_PACKED VDAgentKeyval { > > + uint32_t keyval; > > + uint32_t flags; > > +} VDAgentKeyval; > > + > > typedef struct SPICE_ATTR_PACKED VDAgentReply { > > uint32_t type; > > uint32_t error; > > @@ -209,6 +225,7 @@ > > VD_AGENT_CAP_SPARSE_MONITORS_CONFIG, > > VD_AGENT_CAP_GUEST_LINEEND_LF, > > VD_AGENT_CAP_GUEST_LINEEND_CRLF, > > + VD_AGENT_CAP_KEYVAL, > > VD_AGENT_END_CAP, > > }; > > > > > As discussed in summary mail, I think this key event should be on input channel, > to avoid key/mouse event synchronization issues on two channels and because > it is a substitute (not a complement) to existing KeyDown/KeyUp messages. OK, will rewrite. _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel