On Thu, Oct 03, 2013 at 09:43:31AM -0400, Marc-André Lureau wrote: > > > ----- Original Message ----- > > On Thu, Oct 03, 2013 at 08:51:15AM -0400, Marc-André Lureau wrote: > > > > > > > > > ----- Original Message ----- > > > > On Thu, Oct 03, 2013 at 01:53:55PM +0200, Marc-André Lureau wrote: > > > > > palette_get() used to return a ref, and palette_release() used to > > > > > release that ref. > > > > > > > > > > Since ed877341, the palette is no longer refcount'ed, since its usage > > > > > is > > > > > exclusively local in common/canvas code. > > > > > > > > > > palette_release() shouldn't remove the palette from the cache. > > > > > > > > Doesn't this mean we will keep some palettes in the cache forever? If > > > > yes, > > > > some guarantee that the memory used by these palettes is bounded? > > > > > > palette_get() / palette_release() always come in pair > > > > Ah right, looks like we can even go with removal then: > > Sure, but you'll have to fix server code too then. Ah right, this is shared. It seems the server is not using it, but the old client is :-/ ACK Christophe
Attachment:
pgpjIChUJC7P1.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel