Re: [PATCH spice-gtk 2/2] display: cache id is uint64_t

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 03, 2013 at 01:53:56PM +0200, Marc-André Lureau wrote:
> ---
>  gtk/channel-display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gtk/channel-display.c b/gtk/channel-display.c
> index e0f17eb..a57453f 100644
> --- a/gtk/channel-display.c
> +++ b/gtk/channel-display.c
> @@ -551,7 +551,7 @@ static SpicePalette *palette_get(SpicePaletteCache *cache, uint64_t id)
>      return cache_find(c->palettes, id);
>  }
>  
> -static void palette_remove(SpicePaletteCache *cache, uint32_t id)
> +static void palette_remove(SpicePaletteCache *cache, uint64_t id)
>  {
>      SpiceDisplayChannelPrivate *c =
>          SPICE_CONTAINEROF(cache, SpiceDisplayChannelPrivate, palette_cache);

ACK. I did not manage to get gcc to warn about the implicit cast from
uint64_t to uint32_t in the palette_remove callers (tried -Wconversion)

Christophe

Attachment: pgpLyE77gzIac.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]