Re: [PATCH spice-gtk 1/4] proto: comment future surface flags usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 10, 2013 at 04:43:36PM +0200, Marc-André Lureau wrote:
> ---
>  spice.proto | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/spice.proto b/spice.proto
> index 5eede6b..8aa35c1 100644
> --- a/spice.proto
> +++ b/spice.proto
> @@ -425,6 +425,8 @@ flags8 string_flags {
>  };
>  
>  flags32 surface_flags {
> +    /* Adding flags requires some caps check, since old clients only
> +       treat this value as an enum (== PRIMARY test) */

maybe 'treat this value as an enum (== PRIMARY test) rather than a bit
field' would make things clearer when someone reads this comment in 2
years?

Christophe

Attachment: pgpV0oURexkNf.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]