Re: [PATCH xf86-video-qxl 07/11] xspice: add uinput support to vdagent support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +    n = read(uinput_fd, (char *)&inp_event + offset, sizeof(inp_event) - offset);
> +    offset += n;
> +    if (offset < sizeof(inp_event)) {
> +        return;
> +    }

Nit:  you don't handle errors (I realize you're only here when select
indicates read data is present, but still...)

Cheers,

Jeremy

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]