We currently use it only on gcc 4.5 or newer, but it was actually introduced much earlier than that. It's documented in gcc 2.95.3 manual: http://gcc.gnu.org/onlinedocs/gcc-2.95.3/gcc_4.html#SEC84 and glib uses starting from gcc 2.2.5. This commit uses the same minimum version as glib. --- common/macros.h | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/common/macros.h b/common/macros.h index cf7aaad..47289be 100644 --- a/common/macros.h +++ b/common/macros.h @@ -19,18 +19,14 @@ #ifndef __MACROS_H #define __MACROS_H -#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 5) -#define SPICE_ATTR_PRINTF(a,b) \ - __attribute__((format(printf,a,b))) -#else -#define SPICE_ATTR_PRINTF(a,b) -#endif /* __GNUC__ */ - #if __GNUC__ > 2 || (__GNUC__ == 2 && __GNUC_MINOR__ >= 5) #define SPICE_ATTR_NORETURN \ __attribute__((noreturn)) +#define SPICE_ATTR_PRINTF(a,b) \ + __attribute__((format(printf,a,b))) #else #define SPICE_ATTR_NORETURN +#define SPICE_ATTR_PRINTF #endif /* __GNUC__ */ -- 1.8.3.1 _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel